[U-Boot] [PATCH] USB: musb_udc: Bugfix musb_peri_rx_ep

Tom Rini trini at ti.com
Thu Sep 13 21:31:19 CEST 2012


On Thu, Sep 13, 2012 at 02:01:43PM -0500, Kim Phillips wrote:
> On Thu, 13 Sep 2012 10:26:31 -0700
> Tom Rini <trini at ti.com> wrote:
> 
> > +				} else {
> > +					if (debug_level > 0)
> > +						serial_printf("ERROR : %s %d"
> > +								" no space "
> > +								"in rcv "
> > +								"buffer\n",
> > +								__func__,
> > +								ep);
> > +				}
> 
> that's pretty bad.

Yes, it is.

> strings are allowed to exceed the 80 column limit, for grep purposes.

Good point, just following existing style to the extreme in this case.

> also, if the conditional logic is reversed, one can regain some of
> that horizontal space, i.e.:

An execellent point.  I'll post v2 which will debug print and return if
the bit is not set.

-- 
Tom


More information about the U-Boot mailing list