[U-Boot] [PATCH] Fix checkpatch warnings about externs in *.c
Marek Vasut
marex at denx.de
Sun Sep 16 15:11:28 CEST 2012
Dear Pavel Herrmann,
> On Sunday 16 September 2012 14:37:16 Marek Vasut wrote:
> > Dear Pavel Herrmann,
> >
> > ...
> >
> > Won't include/sata.h work just fine ?
>
> I feel include/sata.h is a "consumer-facing" header, and implementation
> details such as the array used for all data-retention for command and
> drivers should not be there.
>
> Therefore i created a new header in drivers/block for this purpose, feel
> free to oppose to its name though.
Just add a comment there, no need to create new file for that.
And using "extern" keyword in header file is useless.
Actually, proper accessors might be even better idea that directly exporting an
array.
> Pavel Herrmann
Best regards,
Marek Vasut
More information about the U-Boot
mailing list