[U-Boot] [PATCH v2 13/13] mxc nand: Add support for i.MX5

Scott Wood scottwood at freescale.com
Tue Sep 18 02:36:28 CEST 2012


On Tue, Aug 21, 2012 at 11:04:14PM +0200, Benoît Thébaudeau wrote:
> Signed-off-by: Benoît Thébaudeau <benoit.thebaudeau at advansee.com>
> Cc: Scott Wood <scottwood at freescale.com>
> Cc: Stefano Babic <sbabic at denx.de>
> ---
> Changes for v2:
>  - Fix warning for unused tmp variable in board_nand_init() for NFC V1.
> 
>  .../arch/arm/include/asm/arch-mx5/imx-regs.h       |    9 +
>  .../drivers/mtd/nand/mxc_nand.c                    |  219 +++++++++++++++-----
>  .../include/fsl_nfc.h                              |  149 ++++++++-----
>  .../nand_spl/nand_boot_fsl_nfc.c                   |  114 +++++++---
>  4 files changed, 365 insertions(+), 126 deletions(-)

Unless Tom or Wolfgang object, I'm inclined to drop the objection to
adding new hardware support to nand_spl in this case.  I'd rather see the
support be merged rather than ignored because a contributor has time for
a small job but not a large one.  Plus, this code will likely be reused
by the new SPL support, if this platform is space constrained, so it's
not dead-end effort.

It would be nice, though, if the writenfc/readnfc conversion, comment
reformatting, etc. were separate from the behavioral changes.

-Scott



More information about the U-Boot mailing list