[U-Boot] [PATCH] mx51evk: Add CONFIG_REVISION_TAG

Fabio Estevam festevam at gmail.com
Tue Sep 18 05:24:57 CEST 2012


Hi Benoît ,

On Mon, Sep 17, 2012 at 4:04 PM, Benoît Thébaudeau
<benoit.thebaudeau at advansee.com> wrote:

> +u32 get_board_rev(void)
> +{
> +       return get_cpu_rev();
> +}

Is this enough?  Looking at FSL U-boot there is also a:

static inline void set_board_rev(void)
{
	if ((__REG(GPIO1_BASE_ADDR + 0x0) & (0x1 << 22)) == 0)
		system_rev |= BOARD_REV_2_0 << BOARD_VER_OFFSET;

}

On mx53loco I had very weird problems when kernel was running and it
took me sometime to find out that it was due to wrong detection of the
board revision, so I suggest to double check this to avoid this kind
of problem on mx51evk too.

Regards,

Fabio Estevam


More information about the U-Boot mailing list