[U-Boot] [PATCH v6 3/4] OMAP: networking support for SPL

[Ilya Yanok]

Hi Tom,

On Tue, Sep 18, 2012 at 4:17 AM, Tom Rini <trini at ti.com> wrote:

>
> Please add a GPLv2+ header to the file, thanks.
>

Done.


>
> > diff --git a/lib/vsprintf.c b/lib/vsprintf.c index e38a4b7..6bb819c
> > 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -784,7 +784,7
> > @@ void panic(const char *fmt, ...) vprintf(fmt, args);
> > putc('\n'); va_end(args); -#if defined (CONFIG_PANIC_HANG) +#if
> > defined (CONFIG_PANIC_HANG) || defined(CONFIG_SPL_BUILD) hang();
> > #else udelay (100000);        /* allow messages to go out */
>
> Oh no, this change...  Do we still really need this?
>

Seems like it's not needed anymore. I've removed it.


>
> > diff --git a/net/tftp.c b/net/tftp.c index 59a8ebb..baba8f3 100644
> > --- a/net/tftp.c +++ b/net/tftp.c @@ -7,6 +7,10 @@ */
> >
> > #include <common.h> +#ifdef CONFIG_SPL_BUILD +#undef
> > CONFIG_CMD_TFTPPUT +#undef CONFIG_CMD_TFTPSRV +#endif #include
> > <command.h> #include <net.h> #include "tftp.h"
>
> Missed this.
>

Yes, sorry.


>
> Also I saw a few manual inclusions of <config_uncmd_spl.h>, please fix
> those since mkconfig adds it always.  Thanks.
>

Hm, I can't see any.

I reposted only this patch. Hope it's ok now.

Regards, Ilya.