[U-Boot] [PATCH V3 3/8] disk: introduce get_device()

[Tom Rini]

On Tue, Sep 18, 2012 at 08:25:31PM -0500, Rob Herring wrote:
> On 09/18/2012 08:21 PM, Rob Herring wrote:
> > On 09/18/2012 05:37 PM, Stephen Warren wrote:
> >> From: Stephen Warren <swarren at nvidia.com>
> >>
> >> This patch introduces function get_device(). This looks up a
> >> block_dev_desc_t from an interface name (e.g. mmc) and device number
> >> (e.g. 0). This function is essentially the non-partition-specific
> >> prefix of get_device_and_partition().
> > 
> > Then shouldn't get_device_and_partition just call get_device. Perhaps
> > create get_partition() and then get_device_and_partition is just a wrapper.
> > 
> 
> I should read all the way through the series before replying...
> 
> Anyway, I would squash it all unless you want to have restructuring with
> current functionality and then enhancements.

IMHO, restucture and then enhancements makes the most sense since it
means we can bisect a latent bug easier.  So no need for a v4 to squash
patches down.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120919/f37541a1/attachment.pgp>