[U-Boot] [PATCH v4 2/2] ARM: kirkwood/orion5x: Use reset_cpu definition in include/common.h

Prafulla Wadaskar prafulla at marvell.com
Wed Sep 19 22:44:25 CEST 2012



> -----Original Message-----
> From: Pavel Machek [mailto:pavel at denx.de]
> Sent: 16 September 2012 02:44
> To: Prafulla Wadaskar
> Cc: dinguyen at altera.com; u-boot at lists.denx.de; marex at denx.de;
> dinh.linux at gmail.com; clsee at altera.com; trini at ti.com; sr at denx.de
> Subject: Re: [U-Boot] [PATCH v4 2/2] ARM: kirkwood/orion5x: Use
> reset_cpu definition in include/common.h
> 
> Hi!
> 
> > > From: Dinh Nguyen <dinguyen at altera.com>
> > >
> > > include/common.h has the reset_cpu defined already. No need to
> > > re-define here.
> > >
> > > Signed-off-by: Dinh Nguyen <dinguyen at altera.com>
> > > Signed-off-by: Pavel Machek <pavel at denx.de>
> > > ---
> > >  arch/arm/include/asm/arch-kirkwood/cpu.h |    1 -
> > >  arch/arm/include/asm/arch-orion5x/cpu.h  |    1 -
> > >  2 files changed, 2 deletions(-)
> > >
> > > diff --git a/arch/arm/include/asm/arch-kirkwood/cpu.h
> > > b/arch/arm/include/asm/arch-kirkwood/cpu.h
> > > index d28c51a..7a53c8f 100644
> > > --- a/arch/arm/include/asm/arch-kirkwood/cpu.h
> > > +++ b/arch/arm/include/asm/arch-kirkwood/cpu.h
> > > @@ -155,7 +155,6 @@ struct kwgpio_registers {
> > >  /*
> > >   * functions
> > >   */
> > > -void reset_cpu(unsigned long ignored);
> > >  unsigned char get_random_hex(void);
> > >  unsigned int kw_sdram_bar(enum memory_bank bank);
> > >  unsigned int kw_sdram_bs(enum memory_bank bank);
> > > diff --git a/arch/arm/include/asm/arch-orion5x/cpu.h
> > > b/arch/arm/include/asm/arch-orion5x/cpu.h
> > > index 2f52ca8..17b9b69 100644
> > > --- a/arch/arm/include/asm/arch-orion5x/cpu.h
> > > +++ b/arch/arm/include/asm/arch-orion5x/cpu.h
> > > @@ -251,7 +251,6 @@ struct orion5x_ddr_addr_decode_registers {
> > >  /*
> > >   * functions
> > >   */
> > > -void reset_cpu(unsigned long ignored);
> > >  u32 orion5x_device_id(void);
> > >  u32 orion5x_device_rev(void);
> > >  unsigned int orion5x_winctrl_calcsize(unsigned int sizeval);
> > > --
> >
> > Acked-By: Prafulla Wadaskar <Prafulla at marvell.com>
> >
> > BTW: you could have made this patch independent so that it could be
> pulled independently.
> 
> It is independend... Feel free to just apply it.

Subject [U-Boot] [PATCH v4 2/2] indicates it as a part of patch series. It is confusing to pull just one patch out of any patch series.

It would be good if you can post it as standalone patch for better understanding by others on the mailing list.

This is a process issue, there is no technical issue with this patch :-)

Regards...
Prafulla . . .


More information about the U-Boot mailing list