[U-Boot] [PATCH 03/11] DM: add block controller core

[Marek Vasut]

Dear Pavel Herrmann,

> This core provides unified access to different block controllers (SATA,
> SCSI).

Description of the patch missing or is sub-par. You should work on this skill.

> Signed-off-by: Pavel Herrmann <morpheus.ibis at gmail.com>
> ---
>  Makefile                   |   1 +
>  drivers/blockctrl/Makefile |  42 ++++++
>  drivers/blockctrl/core.c   | 349
> +++++++++++++++++++++++++++++++++++++++++++++ include/dm/blockctrl.h     |
>  75 ++++++++++
>  4 files changed, 467 insertions(+)
>  create mode 100644 drivers/blockctrl/Makefile
>  create mode 100644 drivers/blockctrl/core.c
>  create mode 100644 include/dm/blockctrl.h
> 
> diff --git a/Makefile b/Makefile
> index e43fd9d..4420484 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -304,6 +304,7 @@ LIBS-y += test/libtest.o
>  LIBS-$(CONFIG_DM) += common/dm/libdm.o
>  LIBS-$(CONFIG_DM) += drivers/demo/libdemo.o
>  LIBS-${CONFIG_DM_BLOCK} += drivers/blockdev/libblockdev.o
> +LIBS-${CONFIG_DM_BLOCK} += drivers/blockctrl/libblockctrl.o

${} ? What is this ?

[..]

This handles SCSI? Sata ? what ?

Should this not be called scsi_core ? sata_core ? What did the previous core do? 
sata?  scsi? block? I'm lost.

I stop here, I don't know what this is all about, sorry.

Best regards,
Marek Vasut