[U-Boot] [PATCH v8] [RFC] early_malloc for DM added.

[Wolfgang Denk]

Dear Tomas Hlavacek,

In message <1348416940-20319-1-git-send-email-tmshlvck at gmail.com> you wrote:
> early_malloc for DM with support for more heaps and lightweight
> first heap in the same memory as an early stack.
> 
> Adaptation layer for seamless calling of early_malloc or dlmalloc from
> DM based on init stage added (dmmalloc() and related functions).
> 
> Signed-off-by: Tomas Hlavacek <tmshlvck at gmail.com>
> ---
> Changelog since v5:
> dmmalloc() and all dm* functions has been moved to header, made static
> inline and preprocessor-dependent blocks are reworked.
> early_malloc_active() corrected and made not static.
> s/CONFIG_SYS_DM/CONFIG_DM/ applied.
> 
> Changelog sice v6:
> Check of first heap emptyness in early_brk() has been simplified.
> 
> Changelog since v7:
> dmcalloc() implmentation added.
> Comments added to header.

Your change log does not make much sense to me.  It appears there has
been some dmcalloc() implementation already in v5 (and eearlier?), as
you write there you moved it into the header file.  Now you add it
again?

This changelog is intended to desccribe the difference between the
patch versions, to allow a reviewer to recognize which comments you
addressed, and where you decided otherwise.

Your log does not provide any such information.


Also, please re-read the recommendations for the commit message.
"FOO added" is considered bad; please use something like "add FOO"
instead (i. e. describe what this commit actually does).


Also, please make sure tu run ALL patches through checkpatch before
submitting; your patch throws 4 errors that all need fixing.

Finally, you might want to consult a spell checker every now and then
(see for example "implmentation", "perfrom", etc.).

Thanks.

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"I'm not a god, I was misquoted."                 - Lister, Red Dwarf