[U-Boot] [PATCH 1/3] mmc: sdhci: increase the timeout value for data transfer

[Jaehoon Chung]

Hi Rommel,

On 09/24/2012 11:34 AM, Rommel Custodio wrote:
> Hello Jaehoon,
> 
>> I didn't think so..Our environment is support the
>> CONFIG_SYS_MMC_MAX_BLK_COUNT.
> 
> This is defined in mmc.c right after the include definitions.
> The comment says that:
>   Set block count limit because of 16 bit
>   register limit on some hardware
I known that defined into mmc.c.
After changed the MMC_MAX_BLK_COUNT, it also produced "Transfer data timeout".
When MMC_MAX_BLOCK_COUNT is set to 1, didn't produce the error log.
But it's too late.
> 
> So my use of this define is a bit of a hack too.
> 
> 
>> Did you know how get the timeout value "1000"?
>>
>> If the timeout value "1000" is reasonable, i want
>> to know what basis. Well, i don't think that my
>> timeout value is reasonable.
> 
> I think timeout value was from original creator/maintainer
> of SD/MMC code.
Right, the timeout value has set from original code.
> 
> When trying to read big data off of the SD card, I get the
> timeout too on my platform (ml507). My test consist of reading
> a 26Mb file from the SD card in PIO and DMA mode.
> 
> When the timeout is displayed in the serial console, the block
> count register is not yet zero but there is no error in the
> interrupt status register. The block count value shows the
> same value when I perform the same test.
This timeout value isn't timeout value related with TIMEOUT control register.
Your comment seems to mention the TIMEOUT control register.
(As my understanding..if my understanding is wrong, sorry..)
> 
> For my use, CONFIG_SYS_MMC_MAX_BLK_COUNT = 0x1000 in my
> environment. I did not modify any of the timeout values.
> 
> 
>>
>> Actually i want to remove the timeout value in that function.
>> But then we should be prevent the infinite loop.
> 
> The infinite loop that you mention does not occur in my
> situation.
I also didn't occur the infinite loop.
So i think that we can remove the timeout value in that function.

Best Regards,
Jaehoon Chung
> 
>>
>> Anyway, thanks for your comment. I will check the your opinion.
> 
> HTH
> 
> (replying via gmane since i just joined the list)
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>