[U-Boot] [PATCH 2/2] Tegra20: Move some include files to arch-tegra for sharing with Tegra30

Tom Warren twarren.nvidia at gmail.com
Mon Sep 24 21:51:11 CEST 2012


Stephen,

On Mon, Sep 24, 2012 at 11:04 AM, Stephen Warren <swarren at wwwdotorg.org> wrote:
> On 09/21/2012 02:42 PM, Tom Warren wrote:
>> The move is pretty straight-forward. ap20.h and tegra20.h were renamed to ap.h and tegra.h.
>> Some files remain in arch-tegra20 but 'include' a file in 'arch-tegra' with #defines & structs
>> that will be common between T20 and T30 HW. HW-specific #defines, etc. stay in the 'arch-tegra20'
>> 'root' file.
>
>> diff --git a/arch/arm/include/asm/arch-tegra20/clock.h b/arch/arm/include/asm/arch-tegra20/clock.h
>
> I think this file ends up essentially empty apart from just:
>
> #include <asm/arch-tegra/clock.h>
>
> Should files simply be modified to include that instead; it looks like
> that file includes <asm/arch/clock-tables.h> in order to pick up the
> differences between SoCs.

I did it that way to try to reduce the amount of changes necessary in
Tegra code files (and drivers) - i.e. not have to change every
<asm/arch/clock.h> to <asm/arch-tegra/clock.h>. This is essentially
what we did in the Chrome U-Boot branch(es).

For some header files it was easier to just add the T30
structs/defines, because the HW was a super-set of the T20 version
(clk_rst.h, for example).

>
> Aside from that, or perhaps even if you argue against making that change,
>
> Acked-by: Stephen Warren <swarren at nvidia.com>

Thanks,

Tom


More information about the U-Boot mailing list