[U-Boot] [PATCH v8] [RFC] early_malloc for DM added.
trini at ti.com
Mon Sep 24 23:48:02 CEST 2012
On Sun, Sep 23, 2012 at 06:47:34PM +0200, Tomas Hlavacek wrote:
> Dear Wolfgang Denk,
> On Sun, Sep 23, 2012 at 6:32 PM, Wolfgang Denk <wd at denx.de> wrote:
> >> Changelog since v7:
> >> dmcalloc() implmentation added.
> >> Comments added to header.
> > Your change log does not make much sense to me. It appears there has
> > been some dmcalloc() implementation already in v5 (and eearlier?), as
> > you write there you moved it into the header file. Now you add it
> > again?
> Well no. The dmcalloc function returned always NULL in the early stage
> in the previous versions. The current version of dmcalloc simulates
> calloc also in the early_mallocator stage.
> > Also, please re-read the recommendations for the commit message.
> > "FOO added" is considered bad; please use something like "add FOO"
> > instead (i. e. describe what this commit actually does).
> I will do that.
I would strongly recommend and especially as the DM work moves on you
try using patman to manage the series as it will help you to keep track
of, and format properly, changelogs , run checkpatch and otherwise
encourage you to have the other good habits that help us to focus on
reviewing the changes themselves.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 836 bytes
Desc: Digital signature
More information about the U-Boot