[U-Boot] [RFC PATCH 08/17] spl/powerpc: introduce CONFIG_SPL_INIT_MINIMAL

Scott Wood scottwood at freescale.com
Tue Sep 25 01:52:40 CEST 2012


On 09/24/2012 06:48:28 PM, Tom Rini wrote:
> On Fri, Sep 21, 2012 at 07:01:18PM -0500, Scott Wood wrote:
> 
> > Signed-off-by: Scott Wood <scottwood at freescale.com>
> [snip]
> > diff --git a/arch/powerpc/cpu/mpc85xx/Makefile  
> b/arch/powerpc/cpu/mpc85xx/Makefile
> > index 33e93c8..c51a774 100644
> > --- a/arch/powerpc/cpu/mpc85xx/Makefile
> > +++ b/arch/powerpc/cpu/mpc85xx/Makefile
> > @@ -28,7 +28,25 @@ include $(TOPDIR)/config.mk
> >
> >  LIB	= $(obj)lib$(CPU).o
> >
> > +MINIMAL=
> > +
> > +ifdef CONFIG_SPL_BUILD
> > +ifdef CONFIG_SPL_INIT_MINIMAL
> > +MINIMAL=y
> > +endif
> > +endif
> > +
> > +ifdef MINIMAL
> > +
> > +START = start.o resetvec.o
> > +
> > +COBJS-y	+= cpu_init_early.o tlb.o
> > +COBJS-$(CONFIG_SPL_NAND_MINIMAL) += cpu_init_nand.o
> > +
> > +else
> 
> So, maybe it's just personal preference by why not:
> START = start.o resetvec.o
> ifdef CONFIG_SPL_BUILD
> COBJS-$(CONFIG_SPL_INIT_MINIMAL) += cpu_init_early.o tlb.o
> COBJS-$(CONFIG_SPL_NAND_MINIMAL) += cpu_init_nand.o
> else
> ....

The START line could be factored out, but I don't think the rest works  
-- where would non-minimal SPL pull in its files?

-Scott


More information about the U-Boot mailing list