[U-Boot] [PATCH v3] h2200: Add support for iPAQ h2200 palmtop

[Marek Vasut]

Dear Łukasz Dałek,

> On 26.09.2012 18:13, Marek Vasut wrote:
> > Dear Łukasz Dałek,
> > 
> >> On 26.09.2012 17:29, Marek Vasut wrote:
> >>> Dear Lukasz Dalek,
> >>> 
> >>>> Basic support of HP iPAQ h2200 palmtop. Support includes also USB
> >>>> ethernet gadget.
> >>> 
> >>> Two minor nits ... can you extend the patch description?
> >>> 
> >>>> Signed-off-by: Lukasz Dalek<luk0104 at gmail.com>
> >>>> [...]
> >>>> +h2200                        arm         pxa
> >>>> +h2200_usbeth                 arm         pxa         h2200
> >>>> 
> >>>>   -
> >>> 
> >>> Can you not enable USB ethernet by default?
> >>> 
> >>> [...]
> >> 
> >> I don't understand.
> >> 
> >> make h2200_config creates config without usb ethernet
> >> make h2200_usbeth_config creates config with usb ethernet
> > 
> > Why not just make config with usb ethernet then?
> 
> Sorry but I don't understand. You've asked me that can I not
> enable USB ethernet by default.

I think you misunderstood. I was never against enabling the USB ethernet. I was 
against enabling it before the USB ethernet code is in, so it won't break 
bisectability.

If I did really say so, I'm sorry for the confusion.

> When you type make h2200_config it won't be enabled.
> It will compile simple u-boot with nothing enabled but
> console and serial.
> 
> When you type make h2200_usbeth_config then setup
> will define CONFIG_H2200_USBETH and compile h2200
> with usbeth support.
> 
> So by default (with noting defined) it will compile simple
> h2200 support.
> 
> Łukasz Dałek

Best regards,
Marek Vasut