[U-Boot] [PATCH] usb.h: Add udc_disconnect prototype to usb.h

Marek Vasut marex at denx.de
Thu Sep 27 01:58:29 CEST 2012


Dear Łukasz Dałek,

> On 26.09.2012 17:31, Marek Vasut wrote:
> > Dear Lukasz Dalek,
> > 
> >> PXA25x gadget implements common function usb_disconnect().
> >> This patch adds this function prototype into usb.h for boards using it.
> > 
> > [...]
> > 
> >> +/*
> >> + * This isn't host
> >> + */
> > 
> > The comment doesn't need to be multiline. It'd be cool if it was
> > meaningful ... like "pxa25x can only do gadget mode, thus the following
> > ... etc". Otherwise, we're basically there.
> 
> Ok
> 
> > Can you repost the whole patchset please?
> 
> Whole? Including ethernet driver, pxa cpu detection etc...?
> If so, I'll resend them.

Yes, in correct order please. We're almost there now.

btw. do you want to hack further on uboot? Maybe some PXA improvements cleanups 
etc?

> Łukasz Dałek

Best regards,
Marek Vasut


More information about the U-Boot mailing list