[U-Boot] [PATCH v3 08/18] tegra: Add SOC support for display/lcd

[Simon Glass]

Hi,

On Thu, Jul 19, 2012 at 1:03 AM, Adam Jiang <chaoj at nvidia.com> wrote:
> On Thu, Jul 12, 2012 at 11:25:08PM +0800, Simon Glass wrote:
>> From: Wei Ni <wni at nvidia.com>
>>
>> Add support for the LCD peripheral at the Tegra2 SOC level. A separate
>> LCD driver will use this functionality to configure the display.
>>
>> Mayuresh Kulkarni:
>> - changes to remove bitfields and clean up for submission
>>
>> Simon Glass:
>> - simplify code, move clock control into here, clean-up
>>
>> Signed-off-by: Mayuresh Kulkarni <mkulkarni at nvidia.com>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>> Changes in v3:
>> - Add probe function to read in fdt parameters in display driver
>> - Separate display driver and LCD driver more in fdt
>>
>>  arch/arm/cpu/armv7/tegra2/display.c        |  389 ++++++++++++++++++++

>> +       if (!config->pixel_clock || bpp == -1 ||
>> +                       config->width == -1 || config->height == -1) {
>> +               debug("%s: Pixel parameters missing\n", __func__);
>> +               return -FDT_ERR_NOTFOUND;
>> +       }
>> +
>> +       /* Use a ref-to-sync of 1 always, and take this from the front porch */
>
> ref-to-sync is supposed to be 1 here.
>
>> +       back = fdtdec_get_int(blob, rgb, "left-margin", -1);
>> +       front = fdtdec_get_int(blob, rgb, "right-margin", -1);
>> +       ref = fdtdec_get_int(blob, rgb, "hsync-len", -1);
>> +       if ((back | front | ref) == -1) {
>> +               debug("%s: Horizontal parameters missing\n", __func__);
>> +               return -FDT_ERR_NOTFOUND;
>> +       }
>> +       config->horiz_timing[FDT_LCD_TIMING_REF_TO_SYNC] = 11;
>
> It is assigned to 11.

Thanks - have updated that.

>
> /Adam

Regards,
Simon