[U-Boot] [PATCH] pmc405de and zeus: remove the env_ptr externs

Igor Grinberg grinberg at compulab.co.il
Fri Sep 28 12:04:46 CEST 2012


The env_ptr is already declared in environment.h, so there is no need to
redeclare in board files (especially after including the environment.h)
Remove those declarations.

Signed-off-by: Igor Grinberg <grinberg at compulab.co.il>
Cc: Stefan Roese <sr at denx.de>
Cc: Matthias Fuchs <matthias.fuchs at esd-electronics.com>
---
Stefan, Matthias,
I'm sending from my laptop (not my main development machine) which
does not have the ppc tool chain installed, can you please compile
test these two boards? Thanks!

 board/esd/pmc405de/pmc405de.c |    1 -
 board/zeus/zeus.c             |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/board/esd/pmc405de/pmc405de.c b/board/esd/pmc405de/pmc405de.c
index a60809a..279d7d4 100644
--- a/board/esd/pmc405de/pmc405de.c
+++ b/board/esd/pmc405de/pmc405de.c
@@ -415,7 +415,6 @@ U_BOOT_CMD(eepwren, 2, 0, do_eep_wren,
 
 #if defined(CONFIG_PRAM)
 #include <environment.h>
-extern env_t *env_ptr;
 
 int do_painit(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
 {
diff --git a/board/zeus/zeus.c b/board/zeus/zeus.c
index 272e59b..e7b2f4d 100644
--- a/board/zeus/zeus.c
+++ b/board/zeus/zeus.c
@@ -39,7 +39,6 @@ DECLARE_GLOBAL_DATA_PTR;
 #define REBOOT_DO_POST	0x00000001
 
 extern flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS]; /* info for FLASH chips	*/
-extern env_t *env_ptr;
 
 ulong flash_get_size(ulong base, int banknum);
 void env_crc_update(void);
-- 
1.7.3.4



More information about the U-Boot mailing list