[U-Boot] [PATCH 1/2] remove unnecessary code in ata_piix

[Tom Rini]

On Fri, Sep 28, 2012 at 08:12:21PM +0200, Marek Vasut wrote:

> Dear Pavel Herrmann,
> 
> > We set sata_curr_device to 0 right after returning from init_sata(),
> > so there's no point in setting it to the last scanned driver at this
> > point.  Note: there are more duplicities with cmd_sata, but those
> > might be required, as the code seems to reset the entire controller
> > on every scan, ignoring the requested port number.
> 
> I think that code is valid. It configures the sata_curr_device to
> valid value in case this was not called from the context of the
> command. No?
> 
> I think it can be pulled from the loops above the return 0 though.

Pavel has it right.  A further clean-up would be to make
sata_curr_device be static to common/cmd_sata.c as it's unused /
referenced anywhere else.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20120928/a8acc114/attachment.pgp>