[U-Boot] [PATCH v1 0/9] block: Fix some inconsistencies in block_{read, write} implementors

Tom Rini trini at ti.com
Sat Sep 29 22:51:47 CEST 2012

Hey all,

I ran into this problem while testing Pavel Herrmann's patch to move
externs to <sata.h>.  To fix these problems I've taken over the patch.
Pavel's patch makes all of the sata drivers include <sata.h>, and this
exposed a number of build problems due to type mis-match.  Examining
these mis-matches leads to this series.  Both <ide.h> and <sata.h> set
prototypes for block_dev_desc_t->block_{read,write} implementors that
did not match the prototype.  First we fix these implemenators (and in
the case of ata_piix.[ch] fix a large number of checkpatch issues.  Then
we fix the prototypes in the headers.


Pavel Herrmann (1):
  sata.h: Make all sata/ata drivers include <sata.h>

Tom Rini (8):
  ata_piix: Fix checkpatch issues
  ata_piix: sata_write must take a const void argument.
  dwc_ahsata: Make sata_write() comply with <part.h>
  fsl_sata: Make sata_{read,write}() comply with <part.h>
  pata_bfin: Make sata_{read,write}() comply with <part.h>
  sata_dwc: Make sata_write() use const void, per <part.h>
  sil_sata: Make sata_write() comply with <part.h>
  ide.h: Make ide_(read|write) match block_dev_desc_t

 drivers/block/ata_piix.c     |  455 ++++++++++++++++++++----------------------
 drivers/block/ata_piix.h     |   46 ++---
 drivers/block/dwc_ahsata.c   |    9 +-
 drivers/block/dwc_ahsata.h   |    2 -
 drivers/block/fsl_sata.c     |   13 +-
 drivers/block/pata_bfin.c    |    5 +-
 drivers/block/pata_bfin.h    |    2 -
 drivers/block/sata_dwc.c     |    5 +-
 drivers/block/sata_sil.c     |    7 +-
 drivers/block/sata_sil.h     |    2 -
 drivers/block/sata_sil3114.c |    2 +-
 include/ide.h                |    4 +-
 include/sata.h               |    7 +-
 13 files changed, 260 insertions(+), 299 deletions(-)


More information about the U-Boot mailing list