[U-Boot] [PATCH 65/72] serial: ns16550: Rename serial.c to serial_ns16550.c

Marek Vasut marex at denx.de
Sun Sep 30 15:22:53 CEST 2012


Dear Michal Simek,

[...]

> You are using two coding styles in this file.

Won't surprise me if there were even more.

> One has function return value on one line and then function name
> and the second function return value on one line with function name.
> Will be good to unify it to look the same in the whole file.

Yes, but definitelly not as a part of unintrusive conversion patch. This file 
has so much legacy and look so crappy it needs proper fixing. Patch is welcome 
%^)

> Thanks,
> Michal

Best regards,
Marek Vasut


More information about the U-Boot mailing list