[U-Boot] [PATCH v1 8/8] mpc85xx: introduce the kmp204x reference design support

[Valentin Longchamp]

On 08/20/2013 08:18 PM, Scott Wood wrote:
> On Tue, 2013-08-20 at 08:28 +0200, Valentin Longchamp wrote:
>> On 08/20/2013 02:48 AM, Scott Wood wrote:
>>> On Mon, 2013-08-19 at 17:50 +0200, Valentin Longchamp wrote:
>>>> On 08/13/2013 11:38 PM, Scott Wood wrote:
>>>>> On Fri, 2013-07-26 at 12:02 +0200, Valentin Longchamp wrote:
>>>>>> This patch introduces the support for Keymile's kmp204x reference
>>>>>> design. This design is based on Freescale's P2040/P2041 SoC.
>>>>>>
>>>>>> The peripherals used by this design are:
>>>>>> - DDR3 RAM with SPD support
>>>>>> - SPI NOR Flash as boot medium
>>>>>> - NAND Flash
>>>>>> - 2 PCIe busses (hosts 1 and 3)
>>>>>> - 3 FMAN Ethernet devices (FMAN1 DTSEC1/2/5)
>>>>>> - 3 Local Bus windows, with one dedicated to the QRIO reset/power mgmt
>>>>>>   FPGA
>>>>>> - 2 HW I2C busses
>>>>>> - last but not least, the mandatory serial port
>>>>>>
>>>>>> The board/keymile/kmp204x code is mostly based on Freescale's P2041rdb
>>>>>> support and was changed according to our design (that means essentially
>>>>>> removing what is not present on the designs and a few adaptations).
>>>>>
>>>>> A lot of the copied files have had Freescale copyrights removed...  Also
>>>>> please try to factor shared code out rather than duplicate, where
>>>>> practical.
>>>>
>>>> Well, I had tried to come a first proposal that factored shared code but I was
>>>> advised to copy the code: [1]. For the copyrights I will fix it.
>>>>
>>>> [1]
>>>>
>>>
>>> Did you mean to cite something here?
>>>
>>
>> Oops, yes sorry:
>> http://u-boot.10912.n7.nabble.com/RFC-PATCH-mpc85xx-move-generic-corenet-to-cpu-mpc85xxx-tt153910.html#none
>>
> 
> I think the problem there was that you shared too much, not that sharing
> is bad in general.
> 

OK, then could you please tell me more precisely what you would expect to be
shared and not shared ? Because getting 2 contradictory feedbacks confuses me here.

Valentin