[U-Boot] [v4 1/6] Driver/DDR: Moving Freescale DDR driver to a common driver

Masahiro Yamada yamada.m at jp.panasonic.com
Tue Dec 3 06:15:17 CET 2013


Hello York.

> --- a/arch/powerpc/cpu/mpc83xx/Makefile
> +++ b/arch/powerpc/cpu/mpc83xx/Makefile
> @@ -38,11 +38,11 @@ obj-$(CONFIG_OF_LIBFDT) += fdt.o
>  # Stub implementations of cache management functions for USB
>  obj-y += cache.o
>  
> -ifdef CONFIG_FSL_DDR2
> -obj-$(CONFIG_MPC8349) += ../mpc85xx/ddr-gen2.o
> +ifdef CONFIG_SYS_FSL_DDR2
> +obj-$(CONFIG_MPC8349) += $(SRCTREE)/drivers/ddr/fsl/mpc85xx_ddr_gen2.o

This Makefile is NG.
The object file, mpc85xx_ddr_gen2.o,  is created under a strange path.

Just build with O=  and find out where this object is created.

$ rm -rf build/
$ make O=build MPC8349EMDS_config
Configuring for MPC8349EMDS board...
$ make O=build CROSS_COMPILE=powerpc-linux-
<<snip>>
$ find . -name mpc85xx_ddr_gen2.o
./build/arch/powerpc/cpu/mpc83xx/home/yamada/workspace/u-boot/drivers/ddr/fsl/mpc85xx_ddr_gen2.o



And it also looks weird to me.

Why did you put this code in arch/powerpc/cpu/mpc83xx/Makefie,
not drivers/ddr/fsl/Makefile ?


Best Regards
Masahiro Yamada



More information about the U-Boot mailing list