[U-Boot] [PATCH] netbsd:fix documentation typo.
Sughosh Ganu
urwithsughosh at gmail.com
Thu Dec 12 10:23:12 CET 2013
hi Kees,
On Mon Dec 09, 2013 at 11:28:05AM +0100, Kees Jongenburger wrote:
> From: Kees Jongenburger <kees.jongenburger at gmail.com>
>
> The documentation suggested the arguments where passed over r3-r6
> while the code bellow simply does that over r0-r3.
>
> Cc: Kumar Gala <galak at kernel.crashing.org>
> ---
> common/cmd_bootm.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/common/cmd_bootm.c b/common/cmd_bootm.c
> index ba73f57..084c0e9 100644
> --- a/common/cmd_bootm.c
> +++ b/common/cmd_bootm.c
> @@ -1531,10 +1531,10 @@ static int do_bootm_netbsd(int flag, int argc, char * const argv[],
>
> /*
> * NetBSD Stage-2 Loader Parameters:
> - * r3: ptr to board info data
> - * r4: image address
> - * r5: console device
> - * r6: boot args string
> + * r0: ptr to board info data
> + * r1: image address
> + * r3: console device
> + * r3: boot args string
Umm, is this not supposed to be processor agnostic -- different
architectures would use different registers to pass these arguments. I
would suggest changing it to something like arg[0-3] instead.
-sughosh
More information about the U-Boot
mailing list