[U-Boot] [PATCH 0/34] Switch over to real Kbuild

[Simon Glass]

Hi Masahiro,


On 11 December 2013 19:53, Masahiro Yamada <yamada.m at jp.panasonic.com> wrote:
> Hello Simon
>
>> > You need to apply above patches beforehand to use this series.
>> > They are simple patches, so I hope they will be reviewed and applied first.
>>
>> Can you please push a branch somewhere with all of these and kbuild?
>
> Sure.
>
> u-boot/master was updated after posting this series.
> (Prerequisite [1] was merged into the mainline.)
> I rebased my local branch and push it to my GitHub space.
>
>
> Please try this:
> git clone git://github.com/masahir0y/u-boot-kbuild.git
> cd u-boot-kbuild
> git checktout kbuild

Thank you, that is much easier.

I'm very impressed with your efforts here - the commits are clean and
easy to understand. I have been through them in turn. I have a few
minor comments...

I see this error turn up in commit 34 (it is fixed in 38):

34: Kbuild: change out-of-tree building
   sandbox: +   sandbox
+/usr/local/google/c/cosarm/src/third_party/u-boot/try-kbuild2/.bm-work/00/arch/sandbox/cpu/os.c:6:20:
fatal error: dirent.h: No such file or directory
+compilation terminated.
35: Kbuild: add dummy obj-y to create built-in.o
36: Makefile: rename scripts/Makefile.build to scripts/Makefile.build.tmp
37: Kbuild: import more build scripts from Linux v3.12 tag
38: Kbuild: use Linux Kernel build scripts
   sandbox:    sandbox
-/usr/local/google/c/cosarm/src/third_party/u-boot/try-kbuild2/.bm-work/00/arch/sandbox/cpu/os.c:6:20:
fatal error: dirent.h: No such file or directory
-compilation terminated.
39: Kbuild: delete temporary build scripts

What will happen with the 'FIX ME's that are generated? e.g.:

+# FIX ME
+ifneq ($(filter lib lib/lzma lib/zlib, $(obj)),)
+ccflags-y := -O2
+endif


Have you done any comparison on build times?

Regards,
Simon