[U-Boot] [PATCH 1/1] arm: mx5: Add fuse supply gate enable in fsl_iim

[Benoît Thébaudeau]

On Friday, December 13, 2013 1:42:10 PM, Benoît Thébaudeau wrote:
> On Thursday, December 12, 2013 5:46:21 PM, Sergey Alyoshin wrote:
> > +#if defined(CONFIG_MX51) || defined(CONFIG_MX53)
> > +static inline void enable_fuse_prog(unsigned char enable)
> > +{
> > +	enable_efuse_prog_gate(enable);
> > +}
> > +#else
> > +static inline void enable_fuse_prog(unsigned char enable) {}
> > +#endif
> > +
> 
> Please drop the 'inline', and move this function after the struct fsl_iim
> type
> definition, i.e. right before prepare_access().
> 
> Also, you don't have to redefine a function, so you could just do:
> +#if !defined(CONFIG_MX51) && !defined(CONFIG_MX53)
> +static void enable_efuse_prog_supply(bool enable) {}
> +#endif
> +

Or even better:
> +#if !defined(CONFIG_MX51) && !defined(CONFIG_MX53)
> +#define enable_efuse_prog_supply(enable)
> +#endif
> +

Best regards,
Benoît