[U-Boot] [UBOOT][PATCH 0/5] qspi: Add AM437x support

[Sourav Poddar]

On Thursday 19 December 2013 02:50 PM, Jagan Teki wrote:
> On Thu, Dec 19, 2013 at 2:28 PM, Sourav Poddar<sourav.poddar at ti.com>  wrote:
>> On Thursday 19 December 2013 02:21 PM, Jagan Teki wrote:
>>> On Thu, Dec 19, 2013 at 2:17 PM, Sourav Poddar<sourav.poddar at ti.com>
>>> wrote:
>>>> On Thursday 19 December 2013 12:49 PM, Jagan Teki wrote:
>>>>> On Thu, Dec 19, 2013 at 12:37 PM, Sourav Poddar<sourav.poddar at ti.com>
>>>>> wrote:
>>>>>> On Thursday 19 December 2013 12:24 PM, Jagan Teki wrote:
>>>>>>> On Mon, Nov 25, 2013 at 4:28 PM, Sourav Poddar<sourav.poddar at ti.com>
>>>>>>> wrote:
>>>>>>>> Hi Jagan,
>>>>>>>>
>>>>>>>> On Thursday 14 November 2013 09:09 PM, Sourav Poddar wrote:
>>>>>>>>> The patch series add support for enabling qspi
>>>>>>>>> on AM43xx at uboot.
>>>>>>>>>
>>>>>>>>> Testing done:
>>>>>>>>> -------------
>>>>>>>>> Wrote a uImage to the flash, read it back and boot the
>>>>>>>>> kernel.
>>>>>>>>>
>>>>>>>>> Jagannadha Sutradharudu Teki (1):
>>>>>>>>>        sf: macronix: Add support for MX25L51235F
>>>>>>>>>
>>>>>>>>> Sourav Poddar (4):
>>>>>>>>>        am43xx: add qspi support
>>>>>>>>>        am437x_epos_evm: add SPL API, QSPI, and serial flash support
>>>>>>>>>        qspi/spi: Add AM43xx specifics changes
>>>>>>>>>        am43xx: add delay before xfer
>>>>>>>>>
>>>>>>>>>       arch/arm/cpu/armv7/am33xx/clock_am43xx.c |    1 +
>>>>>>>>>       arch/arm/include/asm/arch-am33xx/cpu.h   |    4 +++-
>>>>>>>>>       arch/arm/include/asm/arch-am33xx/omap.h  |    1 +
>>>>>>>>>       board/ti/am43xx/mux.c                    |   11 +++++++++++
>>>>>>>>>       drivers/mtd/spi/sf_probe.c               |    2 ++
>>>>>>>>>       drivers/spi/ti_qspi.c                    |   29
>>>>>>>>> ++++++++++++++++++++++++++---
>>>>>>>>>       include/configs/am43xx_evm.h             |   20
>>>>>>>>> ++++++++++++++++++++
>>>>>>>>>       7 files changed, 64 insertions(+), 4 deletions(-)
>>>>>>>>>
>>>>>>>> If these patches seems fine to you, can these be picked?
>>>>>>> Please send the next version patches - fix the comments as we
>>>>>>> discussed
>>>>>>> so
>>>>>>> far.
>>>>>>>
>>>>>> I will send the next version.
>>>>>> But, what about the delay patch, I tried other stuffs but could not see
>>>>>> any
>>>>>> thing
>>>>>> that helps.
>>>>>> So,  I will send the delay patch also as of now, to make it work out of
>>>>>> mainline.
>>>>> I am some how OK with that as that change is in ur driver..
>>>>>
>>>>> Just try this change
>>>>> /* FIXME: comments here... */
>>>>> +#ifdef CONFIG_AM43XX
>>>>> + udelay(100);
>>>>> +#endif
>>>>>
>>>>> And also write the bug log on commit message(means with out delay)
>>>>>
>>>>> Try to ass the testing logs on doc/ - for each time you tested a new
>>>>> flash or new driver.
>>>>>
>>>> Jagan,
>>>>
>>>> Just realised that this patches depends on AM43x base patches which are
>>>> in
>>>> ti-uboot mainline tree. So, what should I do in that case. ?
>>> Send all of them together..!
>>>
>> So, I should send all the base patches also?
> am43xx_evm is already available - all patches means related to spi for
> this board.
> If OK then send
>
>> Note: These dependendt patches are already there in tom ti-uboot mainline
>> tree.
>>
>>
I am getting this error while building with this patches
drivers/spi/built-in.o: In function `spi_setup_slave':
/home/a0131647/clone/u-boot/drivers/spi/ti_qspi.c:180: undefined 
reference to `gpio_request'
/home/a0131647/clone/u-boot/drivers/spi/ti_qspi.c:181: undefined 
reference to `gpio_direction_output'
arm-linux-gnueabihf-ld.bfd: BFD (crosstool-NG 
linaro-1.13.1-4.7-2013.03-20130313 - Linaro GCC 2013.03) 2.23.1 
assertion fail 
/cbuild/slaves/oorts/crosstool-ng/builds/arm-linux-gnueabihf-linux/.build/src/binutils-2.23.1/bfd/elf32-arm.c:7677
arm-linux-gnueabihf-ld.bfd: BFD (crosstool-NG 
linaro-1.13.1-4.7-2013.03-20130313 - Linaro GCC 2013.03) 2.23.1 
assertion fail 
/cbuild/slaves/oorts/crosstool-ng/builds/arm-linux-gnueabihf-linux/.build/src/binutils-2.23.1/bfd/elf32-arm.c:7677
arm-linux-gnueabihf-ld.bfd: error: required section '.rel.plt' not found 
in the linker script
arm-linux-gnueabihf-ld.bfd: final link failed: Invalid operation

I think there is something else that need to be merged from ti-uboot 
tree as I am not facing this
issue there