[U-Boot] [PATCH v2 0/2] usb: gadget: fotg210: workaround & new hardware support

Marek Vasut marex at denx.de
Mon Dec 23 01:55:57 CET 2013


On Monday, December 23, 2013 at 01:50:36 AM, Kuo-Jung Su wrote:
> 2013/12/20 Marek Vasut <marex at denx.de>:
> > On Friday, December 20, 2013 at 05:32:58 AM, Kuo-Jung Su wrote:
> >> From: Kuo-Jung Su <dantesu at faraday-tech.com>
> >> 
> >> 1. It's known that EP0 fifo empty indication is not reliable, an extra
> >> delay is necessary to avoid data corruption while handling packets with
> >> size greater than 64 bytes.
> >> 
> >> 2. Since hardware revision 1.11.0, some fields of interrupt status
> >> registers are now write-1-clear.
> >> 
> >> Changes for v2:
> >>       - usb: gadget: fotg210: add w1c interrupt status support:
> >>         By writting 1 then 0 to get rid of the use of
> >>         CONFIG_USB_GADGET_FOTG210_ISRW1C.
> >>         Thanks for Marek's comments.
> >>       
> >>       - usb: gadget: fotg210: EP0 fifo empty indication is non-reliable
> >>       
> >>         udelay_masked() -> udelay(), and patch comment updates.
> >> 
> >> Kuo-Jung Su (2):
> >>   usb: gadget: fotg210: add w1c interrupt status support
> >>   usb: gadget: fotg210: EP0 fifo empty indication is non-reliable
> >>  
> >>  drivers/usb/gadget/fotg210.c |   15 +++++++++++++++
> >>  1 file changed, 15 insertions(+)
> > 
> > Applied both , thanks!
> > 
> > btw. is this FOTG210 stuff used by any platform or is this just a dead
> > code ?
> 
> It's still an active IP, and the only USB 2.0 (host, device, otg)
> controller we have currently in Faraday.
> 
> It's used in upcoming Faraday A369 SoC patch set (I'm still waiting
> for the dependant NAND driver: ftnandc021 to be commited),
> 
> and the new SoC platforms (For politics reason,  they won't be
> released by myself.) in year 2013.

OK, glad to see this won't be dead code soon. Next time, I suppose it'd be 
better to commit platform first, drivers afterwards, so we dont have dead code 
for an extended period of time.

Best regards,
Marek Vasut


More information about the U-Boot mailing list