[U-Boot] [PATCH v2 1/2] Tegra: fdt: Add/enhance sdhci (mmc) nodes for all T20 DT files

[Tom Warren]

Lucas,

On Mon, Feb 11, 2013 at 10:28 AM, Lucas Stach <dev at lynxeye.de> wrote:
> Hi Tom,
>
> Am Montag, den 11.02.2013, 10:17 -0700 schrieb Tom Warren:
>> Linux dts files were used for those boards that didn't already
>> have sdhci info populated. Tamonten has their own dtsi file with
>> common sdhci nodes (sourced from Linux).
>>
>> Signed-off-by: Tom Warren <twarren at nvidia.com>
>> ---
>> v2:
>> - cleanup comments in dts files/match w/kernel files
>> - add sdhci aliases in all dts files
>> - use tegra20-tamonten.dtsi from the kernel for AD boards
>>
>>  arch/arm/dts/tegra20-tamonten.dtsi               |  489 ++++++++++++++++++++++
>
> I'm not sure if pushing the whole file in this patch is the right thing
> to do.

I didn't want to edit it since we seem to be moving towards using the
Linux DTS files in toto in U-Boot (as per Stephen & Simon). Does it do
any harm to have the whole thing here? Saves some work later. Thierry
- what do you think?

>
>>  arch/arm/dts/tegra20.dtsi                        |   16 +-
>>  board/avionic-design/dts/tegra20-medcom-wide.dts |    1 +
>>  board/avionic-design/dts/tegra20-plutux.dts      |    1 +
>>  board/avionic-design/dts/tegra20-tec.dts         |    1 +
>>  board/compal/dts/tegra20-paz00.dts               |   19 +-
>>  board/compulab/dts/tegra20-trimslice.dts         |   14 +
>>  board/nvidia/dts/tegra20-harmony.dts             |   18 +
>>  board/nvidia/dts/tegra20-seaboard.dts            |   12 +-
>>  board/nvidia/dts/tegra20-ventana.dts             |   15 +
>>  board/nvidia/dts/tegra20-whistler.dts            |   13 +
>>  board/toradex/dts/tegra20-colibri_t20_iris.dts   |    6 +
>>  12 files changed, 595 insertions(+), 10 deletions(-)
>>  create mode 100644 arch/arm/dts/tegra20-tamonten.dtsi
>>
> [...]
>> diff --git a/board/toradex/dts/tegra20-colibri_t20_iris.dts b/board/toradex/dts/tegra20-colibri_t20_iris.dts
>> index c29b43a..0dd4c43 100644
>> --- a/board/toradex/dts/tegra20-colibri_t20_iris.dts
>> +++ b/board/toradex/dts/tegra20-colibri_t20_iris.dts
>> @@ -10,6 +10,7 @@
>>               usb0 = "/usb at c5008000";
>>               usb1 = "/usb at c5000000";
>>               usb2 = "/usb at c5004000";
>> +             sdhci0 = "/sdhci at c8000600";
>>       };
>>
>>       usb at c5000000 {
>> @@ -35,4 +36,9 @@
>>                       compatible = "nand-flash";
>>               };
>>       };
>> +
>> +     sdhci at c8000600 {
>> +             status = "okay";
>> +             bus-width = <4>;
> You are missing the CD GPIO here. It's PC7.
Thanks, I'll add it.

Tom
>
>> +     };
>>  };
>
> Regards,
> Lucas
>
>