[U-Boot] [PATCH 01/14] tegra: spi: rename tegra SPI drivers

[Allen Martin]

On Wed, Feb 13, 2013 at 02:30:26PM -0800, Stephen Warren wrote:
> On 02/12/2013 08:23 PM, Allen Martin wrote:
> > Rename tegra SPI drivers to tegra20_spi and tegra30_spi in preparation
> > for commonization and addition of tegra114_spi.
> 
> This isn't logically quite right. Both types (sflash, slink) of SPI
> controller actually exist on Tegra20, so it isn't right to name them
> after the different chips. It is true that only one is kept for Tegra30
> (slink). As such, it might make sense to simply drop this patch.

Mostly my intention here was to try to make the SPI driver naming less
confusing and to make room for the "new" tegra114 SPI driver.  What do
you think of the following:

tegra_sflash: tegra20 sflash driver
tegra_slink: tegra20 and tegra30 slink driver
tegra_spi: tegra114 and later spi driver

> 
> >  arch/arm/include/asm/arch-tegra/tegra_slink.h   |   84 ------
> >  arch/arm/include/asm/arch-tegra/tegra_spi.h     |   75 -----
> >  arch/arm/include/asm/arch-tegra20/tegra20_spi.h |   75 +++++
> >  arch/arm/include/asm/arch-tegra30/tegra30_spi.h |   84 ++++++
> >  board/nvidia/common/board.c                     |    2 +-
> >  board/nvidia/common/uart-spi-switch.c           |    2 +-
> >  drivers/spi/Makefile                            |    4 +-
> >  drivers/spi/tegra20_spi.c                       |  330 ++++++++++++++++++++++
> >  drivers/spi/tegra30_spi.c                       |  343 +++++++++++++++++++++++
> >  drivers/spi/tegra_slink.c                       |  343 -----------------------
> >  drivers/spi/tegra_spi.c                         |  330 ----------------------
> >  include/configs/cardhu.h                        |    2 +-
> >  include/configs/trimslice.h                     |    2 +-
> >  13 files changed, 838 insertions(+), 838 deletions(-)
> >  delete mode 100644 arch/arm/include/asm/arch-tegra/tegra_slink.h
> >  delete mode 100644 arch/arm/include/asm/arch-tegra/tegra_spi.h
> >  create mode 100644 arch/arm/include/asm/arch-tegra20/tegra20_spi.h
> >  create mode 100644 arch/arm/include/asm/arch-tegra30/tegra30_spi.h
> >  create mode 100644 drivers/spi/tegra20_spi.c
> >  create mode 100644 drivers/spi/tegra30_spi.c
> >  delete mode 100644 drivers/spi/tegra_slink.c
> >  delete mode 100644 drivers/spi/tegra_spi.c
> 
> "git format-patch -M" might have made this easier to spot the changes
> during the renames, assuming there weren't too many edits to make it
> worthwhile.

Yes, sorry, I'll fix for next round.


> 
> I didn't actually review the diffs, since I assume it was just a simple
> rename.

-Allen
-- 
nvpublic