[U-Boot] [PATCH 01/14] tegra: spi: rename tegra SPI drivers

Stephen Warren swarren at wwwdotorg.org
Thu Feb 14 21:18:48 CET 2013


On 02/14/2013 12:58 PM, Allen Martin wrote:
> On Wed, Feb 13, 2013 at 02:30:26PM -0800, Stephen Warren wrote:
>> On 02/12/2013 08:23 PM, Allen Martin wrote:
>>> Rename tegra SPI drivers to tegra20_spi and tegra30_spi in preparation
>>> for commonization and addition of tegra114_spi.
>>
>> This isn't logically quite right. Both types (sflash, slink) of SPI
>> controller actually exist on Tegra20, so it isn't right to name them
>> after the different chips. It is true that only one is kept for Tegra30
>> (slink). As such, it might make sense to simply drop this patch.
> 
> Mostly my intention here was to try to make the SPI driver naming less
> confusing and to make room for the "new" tegra114 SPI driver.  What do
> you think of the following:
> 
> tegra_sflash: tegra20 sflash driver
> tegra_slink: tegra20 and tegra30 slink driver

I'd suggest naming those tegra20_*.

> tegra_spi: tegra114 and later spi driver

... and that tegra114_spi. That way, it's obvious when those IP blocks
were introduced, which will help people know which driver they care about.

Looking closer at the Tegra114 TRM, it looks like they did declare
"slink" a deprecated name, so the Tegra114 block really should be called
"SPI" as you have it. So, disregard my comments about the compatible
value; nvidia,tegra114-spi looks like the correct choice now.


More information about the U-Boot mailing list