[U-Boot] [RFC PATCH v2 02/15] at91: Correct CONFIG_AUTOBOOT_PROMPT definition for pm9263

Simon Glass sjg at chromium.org
Tue Feb 26 06:28:07 CET 2013


Hi Joe,

On Sun, Feb 24, 2013 at 11:53 AM, Joe Hershberger
<joe.hershberger at gmail.com> wrote:
> Hi Simon,
>
> On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass <sjg at chromium.org> wrote:
>> This is not currently used, since autoboot is not enabled for this
>> board, but the string is missing a parameter. Add it.
>>
>
> Why not enable autoboot for this board so that this setting gets testing?

Actually with autoconf this setting is tested, which is how I found
the problem. The old code used #ifdef and so the problem was masked.

Or do you think I should enable because that was probably the board
vendor's indent?

Regards,
Simon

>
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
>> ---
>> Changes in v2: None
>>
>>  include/configs/pm9263.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/include/configs/pm9263.h b/include/configs/pm9263.h
>> index b60a9ad..6f6ddfa 100644
>> --- a/include/configs/pm9263.h
>> +++ b/include/configs/pm9263.h
>> @@ -355,7 +355,7 @@
>>
>>  #define CONFIG_BOOTCOMMAND             "run flashboot"
>>  #define CONFIG_ROOTPATH                        "/ronetix/rootfs"
>> -#define CONFIG_AUTOBOOT_PROMPT         "autoboot in %d seconds\n"
>> +#define CONFIG_AUTOBOOT_PROMPT         "autoboot in %d seconds\n", bootdelay
>>
>>  #define CONFIG_CON_ROT                 "fbcon=rotate:3 "
>>  #define CONFIG_BOOTARGS                        "root=/dev/mtdblock4 rootfstype=jffs2 "\
>> --
>> 1.8.1.3
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot


More information about the U-Boot mailing list