[U-Boot] [RFC PATCH v2 02/15] at91: Correct CONFIG_AUTOBOOT_PROMPT definition for pm9263

Joe Hershberger joe.hershberger at gmail.com
Wed Feb 27 09:40:15 CET 2013


Hi Simon,

On Mon, Feb 25, 2013 at 11:28 PM, Simon Glass <sjg at chromium.org> wrote:
> Hi Joe,
>
> On Sun, Feb 24, 2013 at 11:53 AM, Joe Hershberger
> <joe.hershberger at gmail.com> wrote:
>> Hi Simon,
>>
>> On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass <sjg at chromium.org> wrote:
>>> This is not currently used, since autoboot is not enabled for this
>>> board, but the string is missing a parameter. Add it.
>>>
>>
>> Why not enable autoboot for this board so that this setting gets testing?
>
> Actually with autoconf this setting is tested, which is how I found
> the problem. The old code used #ifdef and so the problem was masked.
>
> Or do you think I should enable because that was probably the board
> vendor's indent?

What I was thinking is that if the board sets the configuration for
this, then they surely want this feature to work.  It should be
enabled by default for this board (unless the maintainer explicitly
declares no, in which case the configuration should be removed
completely).


More information about the U-Boot mailing list