[U-Boot] [RFC PATCH v2 02/15] at91: Correct CONFIG_AUTOBOOT_PROMPT definition for pm9263

[Simon Glass]

+Ilko Iliev <iliev at ronetix.at> again

Hi Joe,

On Wed, Feb 27, 2013 at 12:40 AM, Joe Hershberger
<joe.hershberger at gmail.com> wrote:
> Hi Simon,
>
> On Mon, Feb 25, 2013 at 11:28 PM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Joe,
>>
>> On Sun, Feb 24, 2013 at 11:53 AM, Joe Hershberger
>> <joe.hershberger at gmail.com> wrote:
>>> Hi Simon,
>>>
>>> On Sun, Feb 24, 2013 at 11:26 AM, Simon Glass <sjg at chromium.org> wrote:
>>>> This is not currently used, since autoboot is not enabled for this
>>>> board, but the string is missing a parameter. Add it.
>>>>
>>>
>>> Why not enable autoboot for this board so that this setting gets testing?
>>
>> Actually with autoconf this setting is tested, which is how I found
>> the problem. The old code used #ifdef and so the problem was masked.
>>
>> Or do you think I should enable because that was probably the board
>> vendor's indent?
>
> What I was thinking is that if the board sets the configuration for
> this, then they surely want this feature to work.  It should be
> enabled by default for this board (unless the maintainer explicitly
> declares no, in which case the configuration should be removed
> completely).

I don't disagree with you, but I think that is a matter for the board
maintainer. I found a minor problem in the config file which I fixed.
But I don't really think I want to enable CONFIG_AUTOBOOT_KEYED,
select some values for CONFIG_AUTOBOOT_DELAY_STR2, etc. as well. For
my purposes I just need the board to continue to boot.

Somehow we dropped Ilko Iliev <iliev at ronetix.at> off the Cc here, so
have re-added.

Regards,
Simon