[U-Boot] [PATCH 2/2] powerpc/c29xpcie: add support for C29XPCIE board

[Wolfgang Denk]

Dear y at tx30smr01.am.freescale.net,

In message <1372661036-11828-2-git-send-email-y> you wrote:
> From: Mingkai Hu <Mingkai.Hu at freescale.com>
> 
> C29XPCIE board is a series of Freescale PCIe add-in cards to perform
> as public key crypto accelerator or secure key management module. It
> includes C293PCIE board, C293PCIE board and C291PCIE board.
> 
>  - 512KB platform SRAM in addition to 512K L2 Cache/SRAM
>  - 512MB soldered DDR3 32bit memory
>  - CPLD System Logic
>  - 64MB x16 NOR flash and 4GB x8 NAND flash
>  - 16MB SPI flash
> 
> Signed-off-by: Mingkai Hu <Mingkai.Hu at freescale.com>
> Singed-off-by: Po Liu <Po.Liu at freescale.com>
> ---
> Base on git://git.denx.de/u-boot.git
>  board/freescale/c29xpcie/Makefile   |  34 +++
>  board/freescale/c29xpcie/c29xpcie.c | 150 +++++++++++
>  board/freescale/c29xpcie/cpld.c     | 155 ++++++++++++
>  board/freescale/c29xpcie/cpld.h     |  53 ++++
>  board/freescale/c29xpcie/ddr.c      |  89 +++++++
>  board/freescale/c29xpcie/law.c      |  22 ++
>  board/freescale/c29xpcie/tlb.c      |  89 +++++++
>  boards.cfg                          |   2 +
>  include/configs/C29XPCIE.h          | 490 ++++++++++++++++++++++++++++++++++++
>  9 files changed, 1084 insertions(+)
>  create mode 100644 board/freescale/c29xpcie/Makefile
>  create mode 100644 board/freescale/c29xpcie/c29xpcie.c
>  create mode 100644 board/freescale/c29xpcie/cpld.c
>  create mode 100644 board/freescale/c29xpcie/cpld.h
>  create mode 100644 board/freescale/c29xpcie/ddr.c
>  create mode 100644 board/freescale/c29xpcie/law.c
>  create mode 100644 board/freescale/c29xpcie/tlb.c
>  create mode 100644 include/configs/C29XPCIE.h

Patch versionmissing.
History of pach changes missing.

Entry to MAINTAINERS file missing.

> +/*
> + * Internal Definitions
> + *
> + * Boot Flags
> + */
> +#define BOOTFLAG_COLD	0x01		/* Normal Power-On: Boot from FLASH */
> +#define BOOTFLAG_WARM	0x02		/* Software reboot */

Scott asked you before to clean up this file.  Please do not simply
ignore review comments like that!!


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Der Dativ ist dem Genitiv sein Tod.