[U-Boot] Backport of DWC3 and xHCI stack from Linux kernel to uBoot

Marek Vasut marex at denx.de
Tue Jul 2 23:55:21 CEST 2013


Hello Wolfgang,

> Dear Dan Murphy,
> 
> In message <1372778113-26053-1-git-send-email-dmurphy at ti.com> you wrote:
> > This patch series has been generated in an effort to get comments on
> > the implementation of the dwc and xHCI code within the uBoot.
> 
> This patch series generates a number of checkpatch errors / warnings.

This is to be expected.

> OK, some of these (like the "Avoid CamelCase") relate to already
> existing code so there is little chance to fix them here and now, bot
> others (like "ERROR: trailing statements should be on next line",
> "WARNING: line over 80 characters", "CHECK: if this code is redundant
> consider removing it", "WARNING: Single statement macros should not
> use a do {} while (0) loop", "CHECK: memory barrier without comment",
> "WARNING: __packed is preferred over __attribute__((packed))", ...)
> should indeed be fixed.

Agreed. It'd be nice to fix the existing code in mainline Linux too btw.

Best regards,
Marek Vasut


More information about the U-Boot mailing list