[U-Boot] [PATCH v4] powerpc/c29xpcie: add support for C29XPCIE board

[Scott Wood]

On 07/03/2013 03:38:14 AM, Po Liu wrote:
> +	/* TLB 1 */
> +	SET_TLB_ENTRY(1, 0xfffff000, 0xfffff000,
> +			MAS3_SX|MAS3_SW|MAS3_SR, MAS2_I|MAS2_G,
> +			0, 0, BOOKE_PAGESZ_4K, 1),

Again, does this ever get used?  Could you try removing it and seeing  
what happens?

I suspect it is no longer used since the change to a cacheable  
spintable.

> +#if defined(CONFIG_RAMBOOT_SPIFLASH)
> +#define CONFIG_SYS_RAMBOOT
> +#define CONFIG_SYS_EXTRA_ENV_RELOC
> +#else
> +#undef CONFIG_SYS_RAMBOOT
> +#endif

When was CONFIG_SYS_RAMBOOT defined before, such that you need to undef  
it here?

> +#define CONFIG_BOARD_EARLY_INIT_R
> +
> +#define CONFIG_SYS_INIT_RAM_LOCK
> +#define CONFIG_SYS_INIT_RAM_ADDR	0xffd00000
> +#define CONFIG_SYS_INIT_RAM_END		0x00004000
> +
> +#define CONFIG_SYS_GBL_DATA_OFFSET	(CONFIG_SYS_INIT_RAM_END \
> +						-  
> GENERATED_GBL_DATA_SIZE)
> +#define CONFIG_SYS_INIT_SP_OFFSET	CONFIG_SYS_GBL_DATA_OFFSET
> +
> +#define CONFIG_SYS_MONITOR_LEN		(512 * 1024)
> +#define CONFIG_SYS_MALLOC_LEN		(1024 * 1024)
> +
> +/* Serial Port */
> +#define CONFIG_CONS_INDEX	1
> +#define CONFIG_SYS_NS16550
> +#define CONFIG_SYS_NS16550_SERIAL
> +#define CONFIG_SYS_NS16550_REG_SIZE	1
> +#define CONFIG_SYS_NS16550_CLK		get_bus_freq(0)
> +
> +#define CONFIG_SERIAL_MULTI		/* Enable both serial ports */
> +#define CONFIG_SYS_CONSOLE_IS_IN_ENV
> +
> +#define CONFIG_SYS_BAUDRATE_TABLE	\
> +	{300, 600, 1200, 2400, 4800, 9600, 19200, 38400, 57600, 115200}
> +
> +#define CONFIG_SYS_NS16550_COM1	(CONFIG_SYS_CCSRBAR+0x4500)
> +#define CONFIG_SYS_NS16550_COM2	(CONFIG_SYS_CCSRBAR+0x4600)
> +
> +/* Use the HUSH parser */
> +#define CONFIG_SYS_HUSH_PARSER
> +#define CONFIG_SYS_PROMPT_HUSH_PS2 "> "

Again, we don't need to define CONFIG_SYS_PROMPT_HUSH_PS2.  This is  
already the default, and the commit that added it as the default seemed  
to suggest that defining it in board config files at all was to be  
deprecated.

If I'm missing something, or you have some specific reason for  
continuing to leave it in, or I'm being unclear, please answer with  
that, rather than just ignoring feedback.

> +#define CONFIG_BOOTDELAY	10	/* -1 disables auto-boot */

Please consider setting this to -1, now that it no longer disables  
compiling the auto-boot code.

-Scott