[U-Boot] [PATCH v4] powerpc/c29xpcie: add support for C29XPCIE board

[Wolfgang Denk]

Dear Po Liu,

In message <1372840694-17354-1-git-send-email-Po.Liu at freescale.com> you wrote:
> From: Mingkai Hu <Mingkai.Hu at freescale.com>
> 
> C29XPCIE board is a series of Freescale PCIe add-in cards to perform
> as public key crypto accelerator or secure key management module. It
> includes C293PCIE board, C293PCIE board and C291PCIE board.

Why don't you keep thread information so we can easily look up
previous review comments?  This is a mandatory requirement when
resubmitting patches - see bullet # 3 at [1]

>  board/freescale/c29xpcie/Makefile   |  34 +++
>  board/freescale/c29xpcie/c29xpcie.c | 151 ++++++++++++
>  board/freescale/c29xpcie/cpld.c     | 134 ++++++++++
>  board/freescale/c29xpcie/cpld.h     |  43 ++++
>  board/freescale/c29xpcie/ddr.c      |  89 +++++++
>  board/freescale/c29xpcie/law.c      |  22 ++
>  board/freescale/c29xpcie/tlb.c      |  83 +++++++
>  boards.cfg                          |   2 +
>  include/configs/C29XPCIE.h          | 475 ++++++++++++++++++++++++++++++++++++
>  9 files changed, 1033 insertions(+)
>  create mode 100644 board/freescale/c29xpcie/Makefile
>  create mode 100644 board/freescale/c29xpcie/c29xpcie.c
>  create mode 100644 board/freescale/c29xpcie/cpld.c
>  create mode 100644 board/freescale/c29xpcie/cpld.h
>  create mode 100644 board/freescale/c29xpcie/ddr.c
>  create mode 100644 board/freescale/c29xpcie/law.c
>  create mode 100644 board/freescale/c29xpcie/tlb.c
>  create mode 100644 include/configs/C29XPCIE.h

Why do you ignore review comments (see [2]) ?

You still fail to add a MAINTAINERS entry!

[1] http://www.denx.de/wiki/view/U-Boot/Patches#Sending_updated_patch_versions
[2] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/164730


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
In the beginning, there was nothing, which exploded.
                                - Terry Pratchett, _Lords and Ladies_