[U-Boot] [PATCHv2 3/8] spi: add TI QSPI driver

Sourav Poddar sourav.poddar at ti.com
Tue Jul 23 11:33:41 CEST 2013


On Tuesday 23 July 2013 02:53 PM, Wolfgang Denk wrote:
> Dear Sourav Poddar,
>
> In message<1374569979-28660-4-git-send-email-sourav.poddar at ti.com>  you wrote:
>> From: Matt Porter<matt.porter at linaro.org>
>>
>> Adds a SPI master driver for the TI QSPI peripheral.
>>
>> Signed-off-by: Matt Porter<matt.porter at linaro.org>
>> Signed-off-by: Sourav Poddar<sourav.poddar at ti.com>
>> ---
>>   drivers/spi/Makefile  |    1 +
>>   drivers/spi/ti_qspi.c |  262 +++++++++++++++++++++++++++++++++++++++++++++++++
>>   2 files changed, 263 insertions(+), 0 deletions(-)
>>   create mode 100644 drivers/spi/ti_qspi.c
> when submitting a new version of a patch or patch series, it is
> mandatory to supply a chancgelog that desribes what you changed
> compareds to previous versions of the patch.  This is necessary so
> that reviewers can see which of their hints were taken into account,
> etc.
>
> This is missing in all you patches of this series.
Ok. will add in the next version.
> Also, please run all your patches through checkpatch _before_
> submitting.  For this patch, I get some "line over 80 characters"
> wanings that need to be fixed.  This should not happen.  Please be
> more careful next time.
>
Hmm...will check and remove.
> Best regards,
>
> Wolfgang Denk
>



More information about the U-Boot mailing list