[U-Boot] [PATCH 7/7 v9] powerpc: p1022ds: add TPL for p1022ds nand boot
Wolfgang Denk
wd at denx.de
Tue Jul 23 12:49:44 CEST 2013
Dear ying.zhang at freescale.com,
In message <1374571024-15729-7-git-send-email-ying.zhang at freescale.com> you wrote:
> From: Ying Zhang <b40530 at freescale.com>
>
> TPL is introduced in the patch "NAND: TPL : introduce the TPL
> based on the SPL", here enable TPL for p1022ds nand boot.
>
> Signed-off-by: Ying Zhang <b40530 at freescale.com>
ERROR: code indent should use tabs where possible
#155: FILE: board/freescale/p1022ds/spl.c:113:
+ (uchar *)CONFIG_ENV_ADDR);$
CHECK: Alignment should match open parenthesis
#155: FILE: board/freescale/p1022ds/spl.c:113:
+ nand_spl_load_image(CONFIG_ENV_OFFSET, CONFIG_ENV_SIZE,
+ (uchar *)CONFIG_ENV_ADDR);
WARNING: please, no spaces at the start of a line
#155: FILE: board/freescale/p1022ds/spl.c:113:
+ (uchar *)CONFIG_ENV_ADDR);$
CHECK: Blank lines aren't necessary before a close brace '}'
#330: FILE: include/configs/P1022DS.h:294:
+#define CONFIG_SYS_NAND_BASE_LIST { CONFIG_SYS_NAND_BASE, }
total: 1 errors, 1 warnings, 2 checks, 223 lines checked
Please fix at least the errors and warnings.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
There are very few personal problems that cannot be solved through a
suitable application of high explosives.
More information about the U-Boot
mailing list