[U-Boot] [PATCH 1/6] ARM: add secure monitor handler to switch to non-secure state

Albert ARIBAUD albert.u.boot at aribaud.net
Sat Jun 1 12:11:56 CEST 2013


On Sat, 1 Jun 2013 12:06:24 +0200, Albert ARIBAUD
<albert.u.boot at aribaud.net> wrote:

> Hi Christoffer,
> 
> On Fri, 31 May 2013 16:50:09 -0700, Christoffer Dall
> <cdall at cs.columbia.edu> wrote:
> 
> > On Fri, May 31, 2013 at 11:23:16AM +0200, Andre Przywara wrote:
> > > On 05/31/2013 03:02 AM, Christoffer Dall wrote:
> 
> > > This is added later in 5/6. For reviewing purposes I split the
> > > patches up to do the non-secure switch only first. Later I add the
> > > bits to actually go to HYP mode.
> > 
> > The splitting of patches is fine, but it would be helpful to explain the
> > scope a little more in the commit text perhaps, maybe I'm just being
> > silly.
> 
> That's the point where a cover letter will be very useful in V2.

Correction: V1 has a cover letter; what I meant and should have said
is, that's where an overall description in the cover letter of how
commits are organized will be very useful in V2.

> Also, speaking of V2 (and, presumably, later versions), that's where
> patman will be useful (see tools/patman/README) as it allows one's
> local branch to contain not only things like cover letter, but also
> patch history, which will be a must IMO for this series.

Correction: maybe/probably Andre used patman already; in this case,
scratch the paragraph above.

Apologies for any misunderstanding,
-- 
Albert.


More information about the U-Boot mailing list