[U-Boot] [PATCH] mx6: mx6qsabrelite/nitrogen6x: Remove incorrect setting of gpio CS signal

Stefano Babic sbabic at denx.de
Mon Jun 3 13:27:07 CEST 2013


On 30/05/2013 16:47, Andrew Gabbasov wrote:
> The number of gpio signal is packed inside CONFIG_SF_DEFAULT_CS macro
> (shifted and or'ed with chip select), so it's incorrect to pass
> that macro directly as an argument to gpio_direction_output() call.
> 
> Also, SPI driver sets the direction and initial value of a gpio,
> used as a chip select signal, before any actual activity happens
> on the bus.
> 
> So, it is safe to just remove the gpio_direction_output call,
> that works incorrectly, thus making no effect, anyway.
> 
> Signed-off-by: Andrew Gabbasov <andrew_gabbasov at mentor.com>
> ---

Applied to u-boot-imx, thanks.

Best regards,
Stefano Babic




-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================


More information about the U-Boot mailing list