[U-Boot] [PATCH 1/1] Add support of IB8315 board

Wolfgang Denk wd at denx.de
Mon Jun 3 20:53:20 CEST 2013


Dear Sergey,

please do not repost patches without making clear thatthese are
reposts, and without explaining _why_ you are reposting, and what has
been changed.  Please see http://www.denx.de/wiki/U-Boot/Patches for
detail.

In message <94EB659E3D5E594D80696B67540292A2F6FA7966A8 at nov-exch01.astro.local> you wrote:
> --===============1618536833==
> Content-Language: en-US
> Content-Type: multipart/alternative;
> 	boundary="_000_94EB659E3D5E594D80696B67540292A2F6FA7966A8novexch01astr_"
> 
> --_000_94EB659E3D5E594D80696B67540292A2F6FA7966A8novexch01astr_
> Content-Type: text/plain; charset="us-ascii"
> Content-Transfer-Encoding: quoted-printable

And never ever send patches as MIME attachments, always send plain
text only.  You want to use "git format-patch" and "git send-email" to
do that.

> Signed-off-by: Sergey Gerasimov <Sergey.Gerasimov at astrosoft-development.com=
> >
> ---
> board/ib8315/Makefile    |  49 +++
> board/ib8315/sdram.c     | 123 +++++++
> board/ib8315/tqm8315.c   | 194 +++++++++++
> boards.cfg               |   1 +
> drivers/block/fsl_sata.c |  21 ++
> drivers/block/fsl_sata.h |   7 +
> include/configs/IB8315.h | 839 ++++++++++++++++++++++++++++++++++++++++++++=
> +++
> include/sata.h           |   4 +

Entry to MAINTAINERS missing.

> create mode 100644 board/ib8315/sdram.c
> create mode 100644 board/ib8315/tqm8315.c
> create mode 100644 include/configs/IB8315.h

And before posting, please make sure to tun your patch through
checkpatch (as explained in the docs); here we get:

total: 345 errors, 479 warnings, 0 checks, 1270 lines checked

These need to be fixed.

Please also pay attention to correct multiline comment style.

No further review done.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
It is not best to swap horses while crossing the river.
- Abraham Lincoln


More information about the U-Boot mailing list