[U-Boot] net, cpsw: disable gigabit support through plattform data

Heiko Schocher hs at denx.de
Wed Jun 5 12:44:42 CEST 2013


Hello Mugunthan, Tom,

Am 04.06.2013 17:29, schrieb Mugunthan V N:
> On 6/4/2013 8:45 PM, Heiko Schocher wrote:
>> Hello Wolfgang,
>>
>> Am 04.06.2013 17:00, schrieb Wolfgang Denk:
>>> Dear Heiko,
>>>
>>> In message <1370335914-14027-1-git-send-email-hs at denx.de> you wrote:
>>>> add possibility to disable gigabit support through
>>>> plattform data. Current boards should not be affected
>>>> through this patch.
>>> ...
>>>> +		if (phy->speed == 1000) {
>>>> +			if (priv->data.gigabit_en) {
>>>> +				mac_control |= GIGABITEN;
>>>> +			} else {
>>>> +				/* Disable gigabit as it's non-functional */
>>>> +				mac_control &= ~GIGABITEN;
>>>> +				phy->speed = 100;
>>> Is this reliable?  I mean, how do we know it's a 100 Mbps connection
>>> (and not for example a 10 Mbs one) ?
> Phy speed info will be read from phy status itself for configuring
> mac ctrl reg.
>> Indeed. Anyway, I have to check, if this patch is necessary, as Tom
>> noted ...
>>
>> bye,
>> Heiko
> As Tom mentioned this patch is applicable only for initial samples
> as there was a issue with Gig mode packet transfer.
> Now there is no issue with having Gig enabled by default.

Indeed, ethernet works fine without this patch :-)

Sorry for the noise. I delete this patch in patchwork.

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany


More information about the U-Boot mailing list