[U-Boot] [PATCH] cfi_flash: Add prototypes of overridable functions

Wolfgang Denk wd at denx.de
Thu Jun 6 12:02:56 CEST 2013


Dear Masahiro Yamada,

In message <1370505244-5015-1-git-send-email-yamada.m at jp.panasonic.com> you wrote:
> This commit adds some prototypes into include/mtd/cfi_flash.h.
> These functions are defined with a weak attribute in
> drivers/mtd/cfi_flash.c.
> This means they can be overrided by board-specific ones
> if necessary.
> 
> When defining such functions under board/ directory or
> somewhere, cfi_flash.h should be included.
> This makes sure that board-specfic cfi functions
> are defined in a correct prototype.

As is, this would just add dead code.  Please resubmit this with any
patch that would actually make use of this feature.  this would also
allow us to understand why this approch is needed at all.

> +#ifdef CONFIG_CFI_FLASH_USE_WEAK_ACCESSORS

When resubmitting, please keep in mind that new CONFIG_* options like
this must be documented in the README.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Here is an Appalachian version of management's answer  to  those  who
are  concerned  with  the fate of the project: "Don't worry about the
mule. Just load the wagon."         - Mike Dennison's hillbilly uncle


More information about the U-Boot mailing list