[U-Boot] [PATCH V3] ARM: OMAP5: Power: Add more functionality to Palmas driver

[Tom Rini]

On Thu, Jun 06, 2013 at 04:11:32PM +0300, Lubomir Popov wrote:

> Add some useful functions, and the corresponding definitions.
> 
> Add support for powering on the dra7xx_evm SD/MMC LDO
> (courtesy Lokesh Vutla <lokeshvutla at ti.com>).
> 
> Signed-off-by: Lubomir Popov <lpopov at mm-sol.com>

After patching checkpatch.pl to know that printf is a logFunction for
us, I see:
total: 13 errors, 0 warnings, 1 checks, 251 lines checked

Including some serious looking ones about doing if ((err = fn())) which
while I think you have the parens right such that err is tested, not the
assignment of err by fn(), is still not a good thing to do.

Functionality wise, I'm happy with it, and we can review where further
abstractions are needed once we have a 3rd example.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130606/02a0d088/attachment.pgp>