[U-Boot] uboot ERROR nfs: Cannot umount error

[Wolfgang Denk]

Dear jinghui shi,

please, can you post your messages just _once_ ?  Thanks.

In message <CA+cQLjef8F_5LSeyW+jYO30oOrPXfqyXquoqwim2CRrnVNbkAA at mail.gmail.com> you wrote:
> 
> if there is a "Cannot umount" error(NetState = NETLOOP_FAIL), the net
> core does not call the "halt" function of the driver,
> that means the ethernet driver is still working. But before the
> loading(starting) of linux image,
> all DMA devices(my NIC is one of them) should be quieted.
> 
> I wanted to know,
> Why we do not call ethernet driver's "halt" function if there was a
> "Cannot umount" error?

It appears you have discovered a bug.  As this happens only in the
error handling branch of the code, it is no big surprise that this has
not been detected before.  But yes, this should be fixed.

> (I am so sorry that I do not know whether I send this mail to the
> right mail address,

That's OK< but you could / should have added the network custodian to
the Cc: list - see [1]  (I did this now).

> I couldn't find net or nfs's maintainer from u-boot/MAINTAINERS, it
> seems only boards' maintainers are there,

Correct - the MAINTAINERS file lists only board maintainers.  The
U-Boot custodians are listed on the web page [1]

> so this mail to mail addresses contains in nfs.c and net.c. If it is
> wrong, and anyone knows the right ones,
> please give me a help, I will fix it. Thanks)

Thanks for your report.

[1] http://www.denx.de/wiki/U-Boot/Custodians


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Why can you only have two doors on a chicken coop? If it had four  it
would be a chicken sedan.