[U-Boot] [PATCH v2 5/8] sf: winbond: Update the names for W25Q 0x40XX ID's flash parts

[Jagan Teki]

On Thu, Jun 6, 2013 at 11:02 AM, Michal Simek <monstr at monstr.eu> wrote:
> move this discussion back to mailing list.
>
> On 06/05/2013 05:56 PM, Jagan Teki wrote:
>>>>> And are your ok with below representation for common id's parts ?
>>>>> +               .name                   = "W25Q80BL/W25Q80BV",
>>>>> +               .name                   = "W25Q16CL/W25Q16DV",
>>>>> +               .name                   = "W25Q32BV/W25Q32FV_SPI",
>>>>> +               .name                   = "W25Q64CV/W25Q64FV_SPI",
>>>>> +               .name                   = "W25Q128BV/W25Q128FV_SPI",
>>>>> +               .name                   = "W25Q32DW/W25Q32FV_QPI",
>>>>> +               .name                   = "W25Q64DW/W25Q64FV_QPI",
>>>>> +               .name                   = "W25Q128FW/W25Q128FV_QPI",
>>>>
>>>> Any comments on above representation of part names, as the id's to
>>>> these pairs are common.
>>>> This will enhance u-boot sf to support all parts from winbond, but
>>>> seems like different view of names.
>>>>
>>>
>>> what's the difference between that parts?
>>
>> parts were diff in terms of voltages and sone SPI and QPI configurations.
>> but from the manufacture defeat, pair of parts were same ID's
>
> ok.
>
>>> Does software care if it is W25G80BL or BV?
>>> Or software behaviour is the same and there is only difference in voltage
>>> or so.
>>
>> SW is same even if it 1.8 or 3.3 v.
>> The only reason for giving the pair of names to support all different parts
>
> You are supporting them but you are just not list them.
>
>>> I don't care about it so much but it is increase u-boot size.
>> Why does u-boot size increase, is it because of  below representation
>> on name filed
>>       = "W25Q80BL/W25Q80BV"
>
> Just because of longer names which go probably to rodata section.
>
> It is not a problem for me at all.

OK, I can go ahead to applied these.
Let me know for any more concerns.

--
Thanks,
Jagan.