[U-Boot] [PATCH 04/11] MIPS: bootm: refactor initialisation of kernel cmdline

[Daniel Schwierzeck]

2013/6/9 Wolfgang Denk <wd at denx.de>:
> Dear Daniel Schwierzeck,
>
> In message <1370731370-32767-5-git-send-email-daniel.schwierzeck at gmail.com> you wrote:
>> Move initialisation of Linux command line to separate functions.
>> Also add support for bootm subcommand 'cmdline'.
>
>> +static void linux_cmdline_dump(void)
>> +{
>> +#ifdef DEBUG
>> +     int i;
>> +
>> +     printf("## cmdline argv at 0x%p, argp at 0x%p\n",
>> +            linux_argv, linux_argp);
>> +
>> +     for (i = 1; i < linux_argc; i++)
>> +             printf("   arg %03d: %s\n", i, linux_argv[i]);
>> +#endif
>> +}
>
> Please remove the #ifdef here, and change printf() into debug()
> instead.

I will change it

>
>> +             while (next && quote && quote < next) {
>> +                     /* we found a left quote before the next blank
>> +                      * now we have to find the matching right quote
>> +                      */
>
> Incorrect multiline comment style.
>

a left-over from the original code. I will fix it in patch 01/11.

Thanks,
Daniel