[U-Boot] [PATCH] usb: omap: ulpi: fix ulpi reading/writing functions

Lubomir Popov lpopov at mm-sol.com
Mon Jun 10 17:05:54 CEST 2013


Hi Michael,

On 10/06/13 17:23, Michael Trimarchi wrote:
> Fix ulpi reading and writing function.
>  * Both functions need to have the bit31 setted.
>  * Right now uboot use 0 to enumerate port 1 and 1 to
>    enumerate port 2 and so on. Omap code use 1 for port 1 and 2 for port 2.
>    Add a +1 fix the problem
> 
> Signed-off-by: Michael Trimarchi <michael at amarulasolutions.com>
> ---
>  drivers/usb/ulpi/omap-ulpi-viewport.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/ulpi/omap-ulpi-viewport.c b/drivers/usb/ulpi/omap-ulpi-viewport.c
> index 2a42033..4db7fa4 100644
> --- a/drivers/usb/ulpi/omap-ulpi-viewport.c
> +++ b/drivers/usb/ulpi/omap-ulpi-viewport.c
> @@ -61,7 +61,7 @@ static int ulpi_request(struct ulpi_viewport *ulpi_vp, u32 value)
>  
I now see that you have not rebased on a clean u-boot-ti/master. This patch
is incremental to your older version, but without any notification about
this, and without version info in the subject. I guess you shall have to
repost.

Best regards,
Lubomir


More information about the U-Boot mailing list