[U-Boot] [PATCH 2/2] spi: mxc_spi: Use DIV_ROUND_UP at appropriate places

Jagan Teki jagannadh.teki at gmail.com
Fri Jun 14 17:11:06 CEST 2013


On 14-06-2013 18:43, Axel Lin wrote:
> This change slightly improves readability.
>
> Signed-off-by: Axel Lin <axel.lin at ingics.com>
> ---
>   drivers/spi/mxc_spi.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c
> index 5bed858..2ea3228 100644
> --- a/drivers/spi/mxc_spi.c
> +++ b/drivers/spi/mxc_spi.c
> @@ -224,7 +224,7 @@ int spi_xchg_single(struct spi_slave *slave, unsigned int bitlen,
>   	const u8 *dout, u8 *din, unsigned long flags)
>   {
>   	struct mxc_spi_slave *mxcs = to_mxc_spi_slave(slave);
> -	int nbytes = (bitlen + 7) / 8;
> +	int nbytes = DIV_ROUND_UP(bitlen, 8);
>   	u32 data, cnt, i;
>   	struct cspi_regs *regs = (struct cspi_regs *)mxcs->base;
>
> @@ -294,7 +294,7 @@ int spi_xchg_single(struct spi_slave *slave, unsigned int bitlen,
>   	/* Transfer completed, clear any pending request */
>   	reg_write(&regs->stat, MXC_CSPICTRL_TC | MXC_CSPICTRL_RXOVF);
>
> -	nbytes = (bitlen + 7) / 8;
> +	nbytes = DIV_ROUND_UP(bitlen, 8);
>
>   	cnt = nbytes % 32;
>
> @@ -330,7 +330,7 @@ int spi_xchg_single(struct spi_slave *slave, unsigned int bitlen,
>   int spi_xfer(struct spi_slave *slave, unsigned int bitlen, const void *dout,
>   		void *din, unsigned long flags)
>   {
> -	int n_bytes = (bitlen + 7) / 8;
> +	int n_bytes = DIV_ROUND_UP(bitlen, 8);
>   	int n_bits;
>   	int ret;
>   	u32 blk_size;
>

Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki at gmail.com>

--
Thanks,
Jagan.


More information about the U-Boot mailing list